Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downloads iso before calling qemu #2637

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Nov 7, 2023

Issue #, if available:

Description of changes:

In CI we ocassionally will see a timeout in qemu when it tries to download the iso, for either redhat or ubuntu. This changes the flow a bit to download the iso first before calling qemu.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added do-not-merge/work-in-progress size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2023
@jaxesn jaxesn changed the title WIP: downloads iso before calling qemu downloads iso before calling qemu Nov 7, 2023
@jaxesn jaxesn force-pushed the jgw/download-iso branch 2 times, most recently from f607309 to 4cf6f3b Compare November 8, 2023 16:15
@jaxesn
Copy link
Member Author

jaxesn commented Nov 8, 2023

/retest

@jaxesn
Copy link
Member Author

jaxesn commented Nov 8, 2023

/unhold

Copy link
Member

@vignesh-goutham vignesh-goutham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vignesh-goutham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 1a4e584 into aws:main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants