Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduces ensure-<dep> pattern for key host level deps #2523

Closed
wants to merge 1 commit into from

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Oct 2, 2023

Issue #, if available:

Description of changes:

There are a few utils we expect to be on the host. I have seen some of these trip people up in the past. This adds a pattern for adding prereqs to targets in the form ensure-<dep> to help guide people when they are missing deps.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jaxesn. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 2, 2023
@eks-distro-bot
Copy link
Collaborator

@jaxesn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
imagebuilder-1-26-presubmit e2f0380 link true /test imagebuilder-1-26-presubmit
imagebuilder-1-23-presubmit e2f0380 link true /test imagebuilder-1-23-presubmit
imagebuilder-1-27-presubmit e2f0380 link true /test imagebuilder-1-27-presubmit
imagebuilder-1-28-presubmit e2f0380 link true /test imagebuilder-1-28-presubmit
imagebuilder-1-25-presubmit e2f0380 link true /test imagebuilder-1-25-presubmit
imagebuilder-1-24-presubmit e2f0380 link true /test imagebuilder-1-24-presubmit
kind-1-27-tooling-presubmit e2f0380 link true /test kind-1-27-tooling-presubmit
kind-1-25-tooling-presubmit e2f0380 link true /test kind-1-25-tooling-presubmit
kind-1-26-tooling-presubmit e2f0380 link true /test kind-1-26-tooling-presubmit
kind-1-24-tooling-presubmit e2f0380 link true /test kind-1-24-tooling-presubmit
kind-1-28-tooling-presubmit e2f0380 link true /test kind-1-28-tooling-presubmit
kind-1-23-tooling-presubmit e2f0380 link true /test kind-1-23-tooling-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jaxesn jaxesn closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants