improves use of gnu variants on macosx #2522
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/L
| @@ -842,7 +842,8 @@ release: $(RELEASE_TARGETS) | |||
| # Iterate over release branch versions, avoiding branches explicitly marked as skipped | |||
| .PHONY: %/release-branches/all | |||
| %/release-branches/all: | |||
| @for version in $(SUPPORTED_K8S_VERSIONS) ; do \ | |||
| @set -e; \ | |||
There was a problem hiding this comment.
We actually have this configured at the top, however the version of make on mac does not support the global flag. For this specific target, its annoying not to fail on error so adding it specifically.
| @@ -129,7 +149,7 @@ function build::gather_licenses() { | |||
| # data about each dependency to generate the amazon approved attribution.txt files | |||
| # go-deps is needed for module versions | |||
| # go-licenses are all the dependencies found from the module(s) that were passed in via patterns | |||
| build::common::echo_and_run go list -deps=true -json ./... | jq -s '' > "${outputdir}/attribution/go-deps.json" | |||
| build::common::echo_and_run go list -deps=true -json ./... | jq -s '.' > "${outputdir}/attribution/go-deps.json" | |||
There was a problem hiding this comment.
i updated jq on my mac and the newer version expects ., i validated this works the same on the old jq as well.
jaxesn
force-pushed
the
jgw/better-mac-handling
branch
from
1a15155 to
bfacb4b
Compare
jaxesn
force-pushed
the
jgw/better-mac-handling
branch
from
bfacb4b to
fc4d274
Compare
|
/retest |
|
@jaxesn: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue #, if available:
Description of changes:
We had a common "pattern" for certain tools, such as sed + tar +date, where on mac we would try and find the gnu build, which is installable via brew. This introduces a helper and refactors our usage of this pattern so its consistent throughout our scripts.
This will also make it a bit more easier to track which brew formulas someone should install if building locally. I plan to update the building-locally doc in a future PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.