Use same uid as host in docker builder container #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/S
g-gaston
force-pushed
the
permissions-docker-builder-host
branch
from
3914012 to
c1c69ed
Compare
jaxesn
approved these changes
Sep 27, 2023
|
/hold |
This makes the host user the owner of any file created by the eks-a builder container. This is particulary useful for any downloaded go module and the cache created during build. Without this change, those folder would be owned by root, which can make following go compilations fail when run from the host directly.
g-gaston
force-pushed
the
permissions-docker-builder-host
branch
from
c1c69ed to
5c8d8a8
Compare
jaxesn
approved these changes
Sep 27, 2023
|
/unhold |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaxesn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This makes the host user the owner of any file created by the eks-a builder container. This is particularly useful for any downloaded go module and the cache created during build. Without this change, those folder would be owned by root, which can make following go compilations fail when run from the host directly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.