Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev changes to mainline #175

Merged
merged 13 commits into from
Jan 28, 2025
Merged

merge dev changes to mainline #175

merged 13 commits into from
Jan 28, 2025

Conversation

bhallasaksham
Copy link
Contributor

Description of changes:

  • Revert NativeAot change for dotnet package
  • Minor updates to tests and docs

Testing done:

  • Ran gMSA API integration tests

[root@ip-10-0-1-233 build]# sudo -E api/tests/gmsa_api_integration_test
[==========] Running 6 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 6 tests from GmsaIntegrationTest
[ RUN      ] GmsaIntegrationTest.HealthCheck_Test
[       OK ] GmsaIntegrationTest.HealthCheck_Test (4 ms)
[ RUN      ] GmsaIntegrationTest.A_AddNonDomainJoinedKerberosLeaseMethod_Test
[       OK ] GmsaIntegrationTest.A_AddNonDomainJoinedKerberosLeaseMethod_Test (1474 ms)
[ RUN      ] GmsaIntegrationTest.B_RenewNonDomainJoinedKerberosLeaseMethod_Test
[       OK ] GmsaIntegrationTest.B_RenewNonDomainJoinedKerberosLeaseMethod_Test (132 ms)
[ RUN      ] GmsaIntegrationTest.C_DeleteKerberosLeaseMethod_Test
[       OK ] GmsaIntegrationTest.C_DeleteKerberosLeaseMethod_Test (7 ms)
[ RUN      ] GmsaIntegrationTest.A_AddKerberosArnLeaseMethod_Test
[       OK ] GmsaIntegrationTest.A_AddKerberosArnLeaseMethod_Test (562 ms)
[ RUN      ] GmsaIntegrationTest.B_RenewKerberosArnLeaseMethod_Test
[       OK ] GmsaIntegrationTest.B_RenewKerberosArnLeaseMethod_Test (339 ms)
[----------] 6 tests from GmsaIntegrationTest (2520 ms total)

[----------] Global test environment tear-down
[==========] 6 tests from 1 test suite ran. (2520 ms total)
[  PASSED  ] 6 tests.
  • Ran SQL tests
Sleep complete. Executing SQL test now.
Command output:
EC2AMAZ-D9I07VH

Command output:
Listing all Docker containers:
IMAGEID: eda8089c450c
Container ID: eda8089c450c
Running commands inside the container:
Ticket cache: FILE:/var/credentials-fetcher/krbdir/krb5cc
Default principal: WebApp02$@CONTOSO.COM

Valid starting     Expires            Service principal
01/23/25 01:56:20  01/23/25 11:56:20  krbtgt/CONTOSO.COM@CONTOSO.COM
	renew until 01/30/25 01:56:20
EmpID       EmpName                                            Designation                                        Department                                         JoiningDate            
----------- -------------------------------------------------- -------------------------------------------------- -------------------------------------------------- -----------------------
          1 CHIN YEN                                           LAB ASSISTANT                                      LAB                                                2022-03-05 03:57:09.967
          2 MIKE PEARL                                         SENIOR ACCOUNTANT                                  ACCOUNTS                                           2022-03-05 03:57:09.967
          3 GREEN FIELD                                        ACCOUNTANT                                         ACCOUNTS                                           2022-03-05 03:57:09.967
          4 DEWANE PAUL                                        PROGRAMMER                                         IT                                                 2022-03-05 03:57:09.967
          5 MATTS                                              SR. PROGRAMMER                                     IT                                                 2022-03-05 03:57:09.967
          6 PLANK OTO                                          ACCOUNTANT                                         ACCOUNTS                                           2022-03-05 03:57:09.967

(6 rows affected)
SQL_SUCCESS_MARKER: 0

Command status: Success
###################################################




------------E2E Test Successful!!------------------




###################################################
  1. Ran stress tests (4000 create lease API calls + 4000 delete lease API calls) in standalone mode

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bhallasaksham bhallasaksham merged commit f6cc14c into mainline Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants