Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify e2e test, add error handling and cleanup #166

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

muskanlalit18
Copy link
Contributor

Description of changes:

  1. Fix failures in e2e test script
  2. Add elegant error handling and retries
  3. Add cleanup of s3 bucket and task definitions
  4. Add detailed print statements for easy debugging

Testing done:
Deployed the stack on my personal account and verified that the test is successful.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@muskanlalit18 muskanlalit18 changed the base branch from dev to mainline January 21, 2025 21:27
@muskanlalit18 muskanlalit18 merged commit c994168 into aws:mainline Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants