Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sql-tests and cleanup after test execution #157

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

bhallasaksham
Copy link
Contributor

@bhallasaksham bhallasaksham commented Jan 14, 2025

Description of changes:

  • Current setup has a lot of individual scripts and code duplication. Spent some time to refactor the existing scripts and adds idempotency
  • Created a new script that will call all setup scripts and execute test. Script will also cleanup after test is complete

Testing done:

  • Ran the run_e2e_test script in my local environment and verified that I can run sql test and have cleanup once the test is done.

  • Will create a follow up PR that updates README and necessary docs.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@smhmhmd smhmhmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the changes require a rerun of CDK ?

@bhallasaksham
Copy link
Contributor Author

Do the changes require a rerun of CDK ?

No, we don't need to re-deploy the cdk

@bhallasaksham bhallasaksham requested review from smhmhmd and removed request for smhmhmd January 14, 2025 23:26
@bhallasaksham bhallasaksham merged commit 530a1f8 into aws:dev Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants