Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDK Integration tests #152

Merged
merged 11 commits into from
Jan 7, 2025
Merged

Conversation

muskanlalit18
Copy link
Contributor

Description of changes:

  1. Replace all Active Directory with Contoso
  2. Add environment variables instead of hardcoding in data.json
  3. Update task definition with docker file image name
  4. Update inbound rules in the security group to allow all traffic from self and directory service
  5. Setup windows instance through SSM instead of user data script
    5.1 Add firewall rule to allow remote requests to SQL server
  6. Run sql test inside the docker container and show command output

Testing done:

  1. Deployed stack
  2. Ran the python scripts in order and verified the sql test works as expected
  • copy_credspecs_and_create_task_defs.py
  • update_task_def_and_run_tasks.py
  • run_powershell_script.py
  • update_inbound_rules.py
  • run_sql_test.py

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@muskanlalit18 muskanlalit18 changed the base branch from fixes_for_DNS_and_distinguishedName to dev January 3, 2025 00:47
@smhmhmd smhmhmd changed the title Upadte CDK Integration tests Update CDK Integration tests Jan 3, 2025
cdk/cdk-domainless-mode/app.py Outdated Show resolved Hide resolved
cdk/cdk-domainless-mode/gmsa.ps1 Outdated Show resolved Hide resolved
cdk/cdk-domainless-mode/README.md Show resolved Hide resolved
cdk/cdk-domainless-mode/data.json Outdated Show resolved Hide resolved
cdk/cdk-domainless-mode/gmsa.ps1 Outdated Show resolved Hide resolved
cdk/cdk-domainless-mode/README.md Show resolved Hide resolved
cdk/cdk-domainless-mode/run_powershell_script.py Outdated Show resolved Hide resolved
cdk/cdk-domainless-mode/run_sql_test.py Show resolved Hide resolved
cdk/cdk-domainless-mode/data.json Show resolved Hide resolved
@muskanlalit18 muskanlalit18 merged commit b6344c8 into aws:dev Jan 7, 2025
@bhallasaksham bhallasaksham mentioned this pull request Jan 15, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants