Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix the nlb.additional_listeners field in the "expose multiple ports" example #5063

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

build-with-aws-copilot
Copy link
Contributor

The doc in https://aws.github.io/copilot-cli/docs/manifest/lb-web-service/ uses additional_listeners, and based on my usage it should be additional_listeners, not additional_rules.

It should be additional_listeners
@build-with-aws-copilot build-with-aws-copilot requested a review from a team as a code owner July 10, 2023 23:26
@build-with-aws-copilot build-with-aws-copilot requested review from efekarakus and removed request for a team July 10, 2023 23:26
Copy link
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing the doc!

@Lou1415926 Lou1415926 changed the title Network Load Balancer manifest docs: fix the nlb.additional_listeners field in the "expose multiple ports" example Jul 11, 2023
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51348 50748 🥺 +1.18
macOS (arm) 51548 50956 🥺 +1.16
linux (amd) 45200 44680 🥺 +1.16
linux (arm) 43524 43012 🥺 +1.19
windows (amd) 42024 41548 🥺 +1.15

Copy link
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!! ❤️

@mergify mergify bot merged commit 3adda09 into aws:mainline Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants