Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): static site should quote alias #5003

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

iamhopaul123
Copy link
Contributor

Fixes #4990

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner June 16, 2023 17:01
@iamhopaul123 iamhopaul123 requested review from Lou1415926 and removed request for a team June 16, 2023 17:01
@github-actions
Copy link

github-actions bot commented Jun 16, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 50832 50748 +0.17
macOS (arm) 51032 50956 +0.15
linux (amd) 44752 44680 +0.16
linux (arm) 43076 43012 +0.15
windows (amd) 41608 41548 +0.14

@codecov-commenter
Copy link

Codecov Report

Merging #5003 (63ec214) into mainline (b75b18f) will not change coverage.
The diff coverage is n/a.

❗ Current head 63ec214 differs from pull request most recent head c87f5e7. Consider uploading reports for the commit c87f5e7 to get more accurate results

@@            Coverage Diff            @@
##           mainline    #5003   +/-   ##
=========================================
  Coverage     70.17%   70.17%           
=========================================
  Files           289      289           
  Lines         41811    41811           
  Branches        285      285           
=========================================
  Hits          29340    29340           
  Misses        11057    11057           
  Partials       1414     1414           

@mergify mergify bot merged commit 439f072 into aws:mainline Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get an error when using * in Static Site http.alias
4 participants