Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: python3.12 testing and linting #48

Merged
merged 8 commits into from
Oct 31, 2023
Merged

fix: python3.12 testing and linting #48

merged 8 commits into from
Oct 31, 2023

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Oct 30, 2023 •
edited
Loading

Issue #, if available: Test Python 3.12 in CI

Description of changes:

  1. Everywhere: Address Linting finds
  2. In tests: Python3.12 throws a TypeError on IO.seek(None), so use IO.seek(4)
  3. tox & GitHub: test on Python3.12 by fixing pip via a conditional in tox.ini
  4. ci-requirements & test/requirements: require setuptools for Python3.12

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@texastony texastony requested a review from a team as a code owner October 30, 2023 20:44
@texastony
Copy link
Contributor Author

Once this PR is approved,
I will modify the branch protections replacing the old required tests with the new ones.

kessplas
kessplas reviewed Oct 30, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
texastony
texastony commented Oct 30, 2023
View reviewed changes
.github/workflows/ci_static-analysis.yaml Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
kessplas
kessplas approved these changes Oct 30, 2023
View reviewed changes
Copy link

@kessplas kessplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@texastony texastony merged commit 6048175 into aws:master Oct 31, 2023
@texastony texastony deleted the tony/fix-py312 branch October 31, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kessplas kessplas kessplas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texastony @kessplas