Fix UnboundLocalError when aiohttp server raises a CancelledError #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armisael
force-pushed
the
bugfix/unbound-local-error
branch
from
3244ac9
to
3baf8ed
Compare
carolabadeer
reviewed
Oct 3, 2022
|
I'm not sure, unfortunately. We have a proxy to some external services, to serve as a cache; such proxy uses aiohttp, and connects to both REST (with httpx) and SOAP (with zeep) services; we recently upgraded from python 3.6 to 3.10 and this error happened once; it's still not clear to me what exactly caused the |
carolabadeer
approved these changes
Oct 17, 2022
carolabadeer
suggested changes
Oct 17, 2022
|
@carolabadeer The tests are failing for a separate issue regarding flask-sqlalchemy. |
carolabadeer
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: In
aiohttpmiddleware, catchBaseExceptioninstead ofExceptionto avoidUnboundLocalError.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.