Added enforced linting #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
- Coverage 82.71% 82.70% -0.01%
==========================================
Files 36 36
Lines 1741 1740 -1
==========================================
- Hits 1440 1439 -1
Misses 301 301
Continue to review full report at Codecov.
|
|
Looks like there's some weirdness with the |
anuraaga
approved these changes
May 28, 2021
| @@ -55,7 +55,7 @@ var RuleCache = { | |||
| if(v !== 0) return v; | |||
| if(a.getName() > b.getName()) | |||
| return 1; | |||
There was a problem hiding this comment.
I'd expect our lint to enforce braces around blocks
There was a problem hiding this comment.
Good call, will add the curly rule
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#329
Description of changes:
Added a top-level
.eslintrc.jsonwhich contains all config, and just extended from it in all subpackages. We use the@typescript-eslint/recommendedandimport/recommendedbase configurations, which don't end up being too opinionated, but is in line with what the AWS SDK uses. I considered adding Prettier, and am still not opposed, but neither the AWS SDK nor OpenTelemetry JS uses it (see open-telemetry/opentelemetry-js#2204 for more on the recent removal).It turns out I can't really add a linting rule to prevent an import like the one that caused #427 because it's a perfectly valid import, but such issues should be caught by the smoke tests now anyway and the repo was long overdue for linting.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.