refs #294, add support for AWS SDK v3 #386
Conversation
|
@willarmiros sorry I messed up and deleted the source branch, this replaces #298 |
|
@willarmiros for some reason |
|
@monken we recently committed a |
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 82.49% 83.10% +0.61%
==========================================
Files 36 37 +1
Lines 1691 1758 +67
==========================================
+ Hits 1395 1461 +66
- Misses 296 297 +1
Continue to review full report at Codecov.
|
|
@willarmiros looks much better now, thanks! Sorry, please re-open. |
There was a problem hiding this comment.
Approving because the last comment isn't really blocking, but would be nice to have to avoid confusion in the future. Nice work @monken!
|
@monken any update on these final couple changes? |
|
Oh I thought we were done. Sorry about this. I'll push the changes today. |
* Revert "Revert PR #386 (#412)" This reverts commit 9e20d2e. * Add proper TypeScript build logic (#417) * build core files to dist directory * fixed unit tests * updated workflows and readme * try to fix windows * fix ls * slashes * no more ls * zstd decompress * see what bin has * removed rsync * fixes * added sh * try xargs instead * cleanups * fixed publishing logic * Redesign AWS SDK V3 instrumentation to use middleware (#416) * updated deps and type file * removed type keyword added deps * remove changes to js * updated versions * finished redesign of aws sdk v3 instrumentation * refactored buildAttributes signature * add compile back to workflow * bumped tsd version instead Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> * removed dependencies and added docs * add back most changes, update types * removed aws-v3 branch from CI * fixed codecov to use dist directory * added blog post link Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
#294
I used typescript for the actual patcher because it makes the code safer and I wanted to make sure that types are maintained when using the XRay patcher. I included the complied JavaScript code as well so that tests can be run without adding more typescript flavor to the project.
There is no captureAWS for now and I also haven't looked at manual mode much because I'm unsure about how to pass in the xray params in a type-safe way.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.