Made setting context modes idempotent #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Jan 6, 2021
EkeMinusYou
pushed a commit
to EkeMinusYou/aws-xray-sdk-node
that referenced
this pull request
Jan 28, 2021
* made setting context modes idempotent * this is why you run tests before committing them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#366
Description of changes:
We appeared to be using the incorrect
getNamespacemethod in ourenableAutomaticModeandenableManualModefunctions. NowenableAutomaticModewill check for an existing namespace before creating a new one, andenableManualModewill only destroy the namespace if one exists (as opposed to potentially creating then immediately destroying a namespace like it does now). So this change will ensure that redundant calls to either method don't have an effect.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.