Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .d.ts files to reflect 'downstreamXRayEnabled' is optional #357

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

TuckerWhitehouse
Copy link
Contributor

Description of changes:

The downstreamXRayEnabled option is, well, optional according to the JSDoc -- it's actually not even mentioned in the README.md, so updating the types to reflect that.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, approved!

@willarmiros willarmiros merged commit 9407138 into aws:master Nov 16, 2020
@TuckerWhitehouse TuckerWhitehouse deleted the downstream-xray-optional branch November 17, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants