Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace instanceof Promise checks with thennable checks #114

Merged
merged 1 commit into from
Apr 19, 2019
Merged

fix: replace instanceof Promise checks with thennable checks #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/mysql/lib/mysql_p.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function patchCreateConnection(mysql) {

mysql['createConnection'] = function patchedCreateConnection() {
var connection = mysql[baseFcn].apply(connection, arguments);
if (connection instanceof Promise) {
if (connection.then instanceof Function) {
connection = connection.then((result) => {
patchObject(result.connection);
return result;
Expand All @@ -54,7 +54,7 @@ function patchCreatePool(mysql) {

mysql['createPool'] = function patchedCreatePool() {
var pool = mysql[baseFcn].apply(pool, arguments);
if (pool instanceof Promise) {
if (pool.then instanceof Function) {
pool = pool.then((result) => {
patchObject(result.pool);
return result;
Expand Down