Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #453 Add support for custom driver detector #461

Closed
wants to merge 5 commits into from
Closed

Issue #453 Add support for custom driver detector #461

wants to merge 5 commits into from

Conversation

amanangira
Copy link

Issue #453

Description of changes:

  • Add support to register user provided driver detectors and export DBAttribute
  • Add helpers for unit tests for snowflake custom driver

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amanangira amanangira requested a review from a team as a code owner March 24, 2024 12:15
@amanangira
Copy link
Author

I am looking for help on how I can test registering of a custom driver detector and test it's usage. Since when using DATA-DOG/sqlmock the driver name is always sqlmock (reference) which never would check for the intended driver when working with the DB mock.

What I intend to do -

  1. Create a unit test case similar to the existing TestOracle to test a custom registered driver detector snowflake.
  2. Use registerSnowflakeDriver to register a snowflake driver detector.
  3. Use mockSnowflakeDB to mock the Ping queries for a snowflake and test it using capturePing.

Step 2 and 3 refer to code in this file.

@amanangira
Copy link
Author

Hi @wangzlei, did you get a chance to look into the test cases?

@amanangira
Copy link
Author

I am not sure whom to tag here. @wangzlei can you direct me?

@amanangira amanangira closed this by deleting the head repository Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant