Fixing sample app #384
Merged
Fixing sample app #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willarmiros
reviewed
Nov 11, 2022
| @@ -4,6 +4,7 @@ github.com/DATA-DOG/go-sqlmock v1.4.1 h1:ThlnYciV1iM/V0OSF/dtkqWb6xo5qITT1TJBG1M | |||
| github.com/DATA-DOG/go-sqlmock v1.4.1/go.mod h1:f/Ixk793poVmq4qj/V1dPUg2JEAKC73Q5eFN3EC/SaM= | |||
| github.com/andybalholm/brotli v1.0.4 h1:V7DdXeJtZscaqfNuAdSRuRFzuiKlHSC/Zh3zl9qY3JY= | |||
| github.com/andybalholm/brotli v1.0.4/go.mod h1:fO7iG3H7G2nSZ7m0zPUDn85XEX2GTukHGRSepvi9Eig= | |||
| github.com/aws/aws-lambda-go v1.34.1 h1:M3a/uFYBjii+tDcOJ0wL/WyFi2550FHoECdPf27zvOs= | |||
There was a problem hiding this comment.
Should we be updating the go.mod file instead?
There was a problem hiding this comment.
If I edit it in the mod file, then it rips it out during "go mod tidy". I think it is because project itself does not have a direct dependency. It depends on a project that depends on a it.
There was a problem hiding this comment.
When I ran "go mod download github.com/aws/aws-lambda-go" on the integration test EC2 instance, then it worked.
So I ran it locally (after moving a copy of the SDK into the same folder) and this is the change.
There was a problem hiding this comment.
I see, it's a transitive dependency of the SDK. Makes sense thanks for looking into this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The sample app used in integration tests needs a dependency on the aws lambda library to run.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.