Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow #274

Merged
merged 8 commits into from
Jan 15, 2021
Merged

Release workflow #274

merged 8 commits into from
Jan 15, 2021

Conversation

bhautikpip
Copy link
Contributor

@bhautikpip bhautikpip commented Jan 14, 2021

Issue #, if available:

Description of changes:

Automated release process for X-Ray Go SDK

Tested this workflow on my fork: https://github.com/bhautikpip/aws-xray-sdk-go/runs/1705266557?check_suite_focus=true

The workflow released v1.3.0 on my fork here - https://github.com/bhautikpip/aws-xray-sdk-go/releases/tag/v1.3.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering how useful this is vs just creating releases in the UI. I guess there's a bit less chance of error though so maybe it's fine.

@bhautikpip
Copy link
Contributor Author

bhautikpip commented Jan 15, 2021

I'm wondering how useful this is vs just creating releases in the UI. I guess there's a bit less chance of error though so maybe it's fine.

Yes the major motivation behind is we still have to clone repo and push tags and for that we need to perform standard release processes so we can reduce that operational burden by having an automated workflow for this simple case as well :)

- name: Checkout master branch
uses: actions/checkout@v2

- name: Initialize Github name and email
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - I dont think this is needed to create a tag (it would be to create a commit)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Yeah I will remove it.

@bhautikpip bhautikpip merged commit f55cc9d into aws:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants