-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release workflow #274
Release workflow #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering how useful this is vs just creating releases in the UI. I guess there's a bit less chance of error though so maybe it's fine.
Yes the major motivation behind is we still have to clone repo and push tags and for that we need to perform standard release processes so we can reduce that operational burden by having an automated workflow for this simple case as well :) |
.github/workflows/release.yml
Outdated
- name: Checkout master branch | ||
uses: actions/checkout@v2 | ||
|
||
- name: Initialize Github name and email |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - I dont think this is needed to create a tag (it would be to create a commit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Yeah I will remove it.
Issue #, if available:
Description of changes:
Automated release process for X-Ray Go SDK
Tested this workflow on my fork: https://github.com/bhautikpip/aws-xray-sdk-go/runs/1705266557?check_suite_focus=true
The workflow released v1.3.0 on my fork here - https://github.com/bhautikpip/aws-xray-sdk-go/releases/tag/v1.3.0
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.