refactor(core): Manifest/LSP fetching should use httpResourceFetcher #6411
+9
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hayemaxi
approved these changes
Jan 22, 2025
|
Just moving this to draft, the web tests are failing because we currently stub out the httpResourceFetcher on web since there was previously node specific code. I just need to re-enable that |
justinmk3
reviewed
Jan 23, 2025
| @@ -133,50 +133,6 @@ export class HttpResourceFetcher implements ResourceFetcher<Response> { | |||
| } | |||
| } | |||
|
|
|||
| export class RetryableResourceFetcher extends HttpResourceFetcher { | |||
There was a problem hiding this comment.
Nice that we can eliminate this! Generally better to have composable concepts, or at least flexible classes, instead of specific subclasses that implement particular compositions.
There was a problem hiding this comment.
Yeah that was one of the motivations for doing all this httpResourceFetcher stuff
justinmk3
approved these changes
Jan 23, 2025
jpinkney-aws
force-pushed
the
manifest-fetcher
branch
from
c5a58ab to
e74f3c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that we've refactored the httpResourceFetcher a little bit we can use that for fetching both the manifest and the language server
Solution
feature/xbranches will not be squash-merged at release time.