Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(amazonq): update tests for messages at different remaining iteration counts #6381

Merged
merged 1 commit into from
Jan 17, 2025
Merged

test(amazonq): update tests for messages at different remaining iteration counts #6381

merged 1 commit into from
Jan 17, 2025

Conversation

siakmun-aws
Copy link
Contributor

Problem

Previously the logic of showing different messages at different remaining iteration counts are tested manually.

Solution

Adding tests to automate the process.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@siakmun-aws siakmun-aws marked this pull request as ready for review January 16, 2025 21:52
@siakmun-aws siakmun-aws requested review from a team as code owners January 16, 2025 21:52
@justinmk3 justinmk3 merged commit f53ca21 into aws:master Jan 17, 2025
26 checks passed
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
@siakmun-aws @karanA-aws
test(amazonq): messages at different remaining iteration counts aws#6381
d8b34f1 


## Problem
Previously the logic of showing different messages at different
remaining iteration counts are tested manually.

## Solution
Adding tests to automate the process.
kevluu-aws pushed a commit to kevluu-aws/aws-toolkit-vscode that referenced this pull request Jan 23, 2025
@siakmun-aws @kevluu-aws
test(amazonq): messages at different remaining iteration counts aws#6381
8a496b9 


## Problem
Previously the logic of showing different messages at different
remaining iteration counts are tested manually.

## Solution
Adding tests to automate the process.
chungjac pushed a commit to chungjac/aws-toolkit-vscode that referenced this pull request Jan 24, 2025
@siakmun-aws @chungjac
test(amazonq): messages at different remaining iteration counts aws#6381
3df08f7 


## Problem
Previously the logic of showing different messages at different
remaining iteration counts are tested manually.

## Solution
Adding tests to automate the process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilk-aws neilk-aws neilk-aws approved these changes

@justinmk3 justinmk3 justinmk3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siakmun-aws @justinmk3 @neilk-aws