deps: Update "aws-sdk" to v2.1692.0 #6340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Response` class in AWS SDK changed the signature of the `nextPage` method, so some tests that were mocking this method had to be updated accordingly (changing the response from `undefined` to `null`).
kevluu-aws
pushed a commit
to kevluu-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 23, 2025
## Problem
The version of the AWSK SDK v2 was outdated 1.5 years, so some newer
functionality was not available.
## Solution
Update the version of `aws-sdk` package to the latest version.
The `Response` class in AWS SDK changed the signature of the `nextPage`
method, so some tests that were mocking this method had to be updated
accordingly (changing the response from `undefined` to `null`).
The definition changed from
```
nextPage(callback?: (err: E, data: D) => void): Request<D, E>|void;
```
(callback optional, can return `void`)
To
```
nextPage(): Request<D, E> | null;
nextPage(callback: (err: E, data: D) => void): void;
```
(can return `null` if no callback. only when a callback is passed
returns `void`)
chungjac
pushed a commit
to chungjac/aws-toolkit-vscode
that referenced
this pull request
Jan 24, 2025
## Problem
The version of the AWSK SDK v2 was outdated 1.5 years, so some newer
functionality was not available.
## Solution
Update the version of `aws-sdk` package to the latest version.
The `Response` class in AWS SDK changed the signature of the `nextPage`
method, so some tests that were mocking this method had to be updated
accordingly (changing the response from `undefined` to `null`).
The definition changed from
```
nextPage(callback?: (err: E, data: D) => void): Request<D, E>|void;
```
(callback optional, can return `void`)
To
```
nextPage(): Request<D, E> | null;
nextPage(callback: (err: E, data: D) => void): void;
```
(can return `null` if no callback. only when a callback is passed
returns `void`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
aws-sdkto v2.1692.0The
Responseclass in AWS SDK changed the signature of thenextPagemethod, so some tests that were mocking this method had to be updated accordingly (changing the response fromundefinedtonull).The definition changed from
(callback optional, can return
void)To
(can return
nullif no callback. only when a callback is passed returnsvoid)Problem
The version of the AWSK SDK v2 was outdated 1.5 years, so some newer functionality was not available.
Solution
Update the version of
aws-sdkpackage to the latest version.feature/xbranches will not be squash-merged at release time.