build(lint): add no-array-for-each and migrate existing cases.

[Hweinstock]

Problem

Many bugs, and confusing behavior stem from developers using an async function within a forEach. This is almost always not desired. Additionally, forEach can lead to bloated implementations when other methods like some, find, reduce, or flatMap are more applicable.

According to https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-array-for-each.md It is also faster with for ... of.

Solution

• Add lint rule: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-array-for-each.md.
• Automatically migrate existing cases with eslint CLI --fix. (able to migrate ~75% of cases).
• For remaining cases, mark as exception.
• Fix a few small lint problems as a result.

---

• Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
• Your code changes must meet the guidelines in CONTRIBUTING.md.
• License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

[Hweinstock]

/runIntegrationTests

[justinmk3]

🚀