telemetry(amazonq): add jobId to all metrics #6241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dhasani23
commented
Dec 13, 2024
| userChoice: `acceptChanges-${patchFilesDescriptions?.content[diffModel.currentPatchIndex].name}`, | ||
| }) | ||
| telemetry.ui_click.emit({ elementId: 'transformationHub_acceptChanges' }) |
There was a problem hiding this comment.
Not useful / redundant, and nobody looked at these ui_click metrics
dhasani23
commented
Dec 13, 2024
| @@ -536,9 +536,9 @@ export class ProposedTransformationExplorer { | |||
| diffModel.saveChanges() | |||
| telemetry.codeTransform_submitSelection.emit({ | |||
There was a problem hiding this comment.
Should be in a run block, have been slowly working on converting all of our metrics to use run blocks, mostly done but the old emit calls are still lingering around in a few places like here
justinmk3
approved these changes
Dec 13, 2024
ntarakad-aws
approved these changes
Dec 13, 2024
justinmk3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
jobIdmissing in some metrics.Solution
Add it.
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.