Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toolkit): rename NestedWizard class and update arch doc #6229

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

vicheey
Copy link
Contributor

@vicheey vicheey commented Dec 13, 2024

Problem

Follow up action item in #6166

Solution

  • Refactor class : NestedWizard --> CompositeWizard
  • Update test file name
  • Add information on arch_development.md about CompositeWizard and how to test using PrompterTester class.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vicheey vicheey marked this pull request as ready for review December 13, 2024 01:29
@vicheey vicheey requested a review from a team as a code owner December 13, 2024 01:29
docs/arch_develop.md Outdated Show resolved Hide resolved
docs/arch_develop.md Outdated Show resolved Hide resolved
docs/arch_develop.md Outdated Show resolved Hide resolved
Co-authored-by: Justin M. Keyes <jmkeyes@amazon.com>
@vicheey vicheey requested a review from justinmk3 December 13, 2024 19:41
@justinmk3 justinmk3 merged commit 0609e5b into aws:master Dec 13, 2024
25 of 26 checks passed
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants