Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(perf): update thresholds in buildIndex tests #6228

Merged
merged 15 commits into from
Dec 12, 2024
Merged

test(perf): update thresholds in buildIndex tests #6228

merged 15 commits into from
Dec 12, 2024

Conversation

Hweinstock
Copy link
Contributor

Problem

Performance test was reliant on dead code removed in #6218

Solution

  • update thresholds to accommodate the change.
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock changed the title test(perf): update thresholds in buildIndex tests to accommodate changes. test(perf): update thresholds in buildIndex tests Dec 12, 2024
@Hweinstock
Copy link
Contributor Author

/runIntegrationTests

@Hweinstock Hweinstock marked this pull request as ready for review December 12, 2024 22:57
@Hweinstock Hweinstock requested a review from a team as a code owner December 12, 2024 22:57
@Hweinstock Hweinstock merged commit 5b5df85 into aws:master Dec 12, 2024
32 of 39 checks passed
@Hweinstock Hweinstock deleted the perf/updateThresholds branch December 12, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk3 justinmk3 justinmk3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hweinstock @justinmk3