Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): correct prompter url button for sam deploy sync build commands #6081

Conversation

vicheey
Copy link
Contributor

@vicheey vicheey commented Nov 21, 2024

Problem

We have been using components from sync.ts, where all prompters created for other command still use samSyncUrl.

Solution

Use correct url link for respective command in all prompter button.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@vicheey vicheey marked this pull request as ready for review November 21, 2024 19:01
@vicheey vicheey requested a review from a team as a code owner November 21, 2024 19:01
@nkomonen-amazon nkomonen-amazon merged commit 4d9644d into aws:master Nov 21, 2024
24 of 25 checks passed
@vicheey vicheey deleted the update-samCommandUrl-buttom-sync-deploy-build-prompters branch November 27, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants