feat(logging): use OutputChannel log level #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
force-pushed
the
standalone
branch
2 times, most recently
from
8f7e5e8 to
10c2209
Compare
This comment was marked as resolved.
This comment was marked as resolved.
justinmk3
force-pushed
the
standalone
branch
2 times, most recently
from
8da7a00 to
a3f9510
Compare
Problem:
Q extension may show error message:
[amazonwebservices.amazon-q-vscode]: Cannot register 'aws.logLevel'. This property is already registered.
Solution:
- Remove the `aws.logLevel` setting from both Toolkit and Q.
- Let the OutputChannel drive the loglevel.
- For very old vscode (older than 1.74), default to "debug" log-level.
microsoft/vscode@2cd8ea2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cannot register 'aws.logLevel'error.Solution
Use the AWS Toolkit Logs" output channel log-level as the source of truth.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.