Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial import of open source icons from VS Code #227

Merged
merged 2 commits into from
Feb 2, 2019

Conversation

awschristou
Copy link
Contributor

Description

There are times when we will want to bring images into this repo from other open source repos. Those repos must have a compatible license, then #207 outlines our approach to how to go about importing images.

This PR serves as an example of what importing icons from another repo looks like.

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@awschristou awschristou requested a review from mpiroc February 2, 2019 00:34
@codecov-io
Copy link

codecov-io commented Feb 2, 2019

Codecov Report

Merging #227 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #227      +/-   ##
===========================================
- Coverage    47.65%   47.61%   -0.05%     
===========================================
  Files           76       76              
  Lines         2478     2478              
  Branches       340      340              
===========================================
- Hits          1181     1180       -1     
- Misses        1297     1298       +1
Impacted Files Coverage Δ
src/shared/utilities/childProcess.ts 96.77% <0%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad060e...c1c3ec5. Read the comment docs.

@awschristou awschristou merged commit ff6b902 into develop Feb 2, 2019
@awschristou awschristou deleted the awschristou/icons-from-vscode branch February 2, 2019 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants