Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unreliable test: "getFileSha384 performance tests" #6225

Closed
justinmk3 opened this issue Dec 12, 2024 · 1 comment
Closed

unreliable test: "getFileSha384 performance tests" #6225

justinmk3 opened this issue Dec 12, 2024 · 1 comment
Labels
tests-ci-cd

Comments

@justinmk3
Copy link
Contributor

Test Details

Log of Test Failure

  1) getFileSha384
       performance tests
         2MB performance tests
           "after all" hook for "2MB - test run 10":

      AssertionError [ERR_ASSERTION]: Expected total user CPU usage for 2MB to be less than 400. Actual user CPU usage was 462.1365886618588
      + expected - actual

      -false
      +true
      
      at assertPerformanceMetrics (/codebuild/output/src2928107957/src/github.com/aws/aws-toolkit-vscode/packages/core/src/shared/performance/performance.ts:182:11)
      at Context.<anonymous> (/codebuild/output/src2928107957/src/github.com/aws/aws-toolkit-vscode/packages/core/src/shared/performance/performance.ts:160:13)
      at Context.fn (/codebuild/output/src2928107957/src/github.com/aws/aws-toolkit-vscode/packages/core/src/test/setupUtil.ts:34:24)
      at processImmediate (node:internal/timers:483:21)
      at process.topLevelDomainCallback (node:domain:161:15)
      at process.callbackTrampoline (node:internal/async_hooks:128:24)
@Hweinstock Hweinstock mentioned this issue Dec 16, 2024
Merged
Hweinstock added a commit that referenced this issue Dec 17, 2024
@Hweinstock
test(perf): increase cpu threshold (#6249)
32c7b76 
## Problem
#6225
- Didn't think 400% could be exceeded, but this one is especially
volatile. Sometimes it barely spikes, and sometimes it goes crazy.
## Solution
- Increase to 500%

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
@Hweinstock
Copy link
Contributor

Resolved by #6249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests-ci-cd
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hweinstock @justinmk3