feat(featureDev): add two new metrics to track startConversation and createUploadUrl issues #645
Conversation
| { | ||
| "name": "amazonq_startConversationInvoke", | ||
| "description": "Captures startConversation process", | ||
| "metadata": [] |
There was a problem hiding this comment.
can you add amazonqConversationId, with flag required: false
sannicm
force-pushed
the
sannicm/featureDev/add_metrics
branch
from
2e62b47 to
831d0ec
Compare
| "name": "amazonq_createUploadUrl", | ||
| "description": "Captures createUploadUrl process", | ||
| "metadata": [ | ||
| { "type": "amazonqConversationId" } |
There was a problem hiding this comment.
Do we also want to capture how long create upload url took?
There was a problem hiding this comment.
Do we? I think that all performance metrics specific to the api are tracked already in the backend operations themselves. toolkit performance metrics should be based in other concepts rather than api latency.
There was a problem hiding this comment.
I'm going to add though repository size for uploadCode though and converastionId in the startConversation (if succeeded)
There was a problem hiding this comment.
Oh whoops, I meant tracking the time on how long it takes to upload the code, not actually how long it takes to create the createUploadUrl. Having the performance metrics on the toolkits telemetry gives us insight onto how long a request takes from a user's perspective which can give us insight if we need to scope down upload size, etc
There was a problem hiding this comment.
It's not really relevant in the scope of this task though
|
/retryBuilds |
| @@ -2771,6 +2771,19 @@ | |||
| { "type": "amazonqGenerateApproachLatency" } | |||
| ] | |||
| }, | |||
| { | |||
| "name": "amazonq_startConversationInvoke", | |||
| "description": "Captures startConversation process", | |||
There was a problem hiding this comment.
the description doesn't tell me anything useful.
how does this differ from amazonq_startChat (which still mentions "/dev", is that correct)?
and the description on amazonq_endChat mentions "end of the conversation".
There was a problem hiding this comment.
This one is specifically related to invoking the api, I will update. It is more evident in this work in progress PR aws/aws-toolkit-vscode#4157
|
please rebase, the failing CI should be fixed by #646 |
sannicm
force-pushed
the
sannicm/featureDev/add_metrics
branch
from
00581a0 to
015a977
Compare
|
/retrybuild |
Problem
The two api operations mentioned do not have a specific metric tracking so they are lost.
Solution
Adding two new metrics to track the api issues and other related to the operations.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.