Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] CBOR Performance Testing #3173

Closed
wants to merge 52 commits into from

Conversation

richardwang1124
Copy link
Contributor

@richardwang1124 richardwang1124 commented Jan 24, 2025

These changes are intended to stay in the cbor-perf-testing branch and NOT to be merged to version-3. This PR was opened to facilitate review and discussion.

Run tests with zsh perf-testing/run-perf-tests.sh <iteration_number>. The actual test with 500 iterations can be executed with zsh perf-testing/run-perf-tests.sh 500.

The test output for each suite (Local only, Secrets Manager, CloudWatch) can be found in their respective directories under perf-testing/test-output. The data.txt file contains the properly formatted results and the raw.txt files contains the measured data points for each test case. The combined outputs are under perf-testing/test-output/combined.

Copy link

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

Copy link

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

Copy link

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

Copy link

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

Copy link

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

Copy link

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

Copy link

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - updates look good.

perf-testing/stats.rb Outdated Show resolved Hide resolved
perf-testing/test_cloudwatch.rb Outdated Show resolved Hide resolved
Copy link

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

@alextwoods
Copy link
Contributor

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

You could probably remove the CI task that checks for the changelog entry in this branch since we never intend to merge it.

Or event invert the logic of it - comment if we DO have a changelog (since not having a changelog for these changes protects us from accidently releasing them if we did accidentally merge this branch).

@richardwang1124 richardwang1124 deleted the cbor-perf-testing branch February 5, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants