New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude locationconstraint from s3 createBucket in us-east-1 #4666

Merged

kuhe merged 1 commit into aws:master from kuhe:fix/s3

Aug 14, 2024

Contributor

kuhe commented Aug 13, 2024 •

edited

Loading

Add region check before adding locationConstraint in us-east-1.

Equivalent functionaltiy in JSv3: https://github.com/aws/aws-sdk-js-v3/blob/main/packages/middleware-location-constraint/src/index.ts

Checklist

npm run test passes
.d.ts file is updated
changelog is added, npm run add-change
run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
run npm run integration if integration test is changed
non-code related change (markdown/git settings etc)

kuhe requested a review from a team as a code owner

August 13, 2024 20:46


          fix: exclude locationconstraint from s3 createBucket in us-east-1

317726b

kuhe force-pushed the fix/s3 branch from c4f38df to 317726b Compare

August 13, 2024 20:46

siddsriv approved these changes

View reviewed changes

trivikr approved these changes

View reviewed changes

kuhe merged commit a1c0ff7 into aws:master

1 check passed

kuhe deleted the fix/s3 branch

August 14, 2024 14:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet