Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/doc client empty nested members #1283

Merged
merged 2 commits into from
Jan 3, 2017

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jan 1, 2017

This PR adds a couple tests to verify #1281 and protect against future regressions.

It also changes the expectations of some tests that assume that the system's path separator will be /, which was causing the unit test suite to fail on Windows.

/cc @chrisradek

@coveralls
Copy link

coveralls commented Jan 1, 2017

Coverage Status

Coverage increased (+0.002%) to 91.927% when pulling 11bb5b9 on jeskew:fix/doc-client-empty-nested-members into 3c76ce8 on aws:master.

@chrisradek
Copy link
Contributor

:shipit:

@jeskew jeskew merged commit e37be2e into aws:master Jan 3, 2017
@jeskew jeskew deleted the fix/doc-client-empty-nested-members branch January 17, 2017 23:29
@arun-gupta
Copy link

Similar value is not found in Java SDK: http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/ClientConfiguration.html Any idea when is that getting added?

@jeskew
Copy link
Contributor Author

jeskew commented Jun 7, 2017

@arun-gupta You will need to open an issue on the AWS SDK for Java repository.

@arun-gupta
Copy link

@jeskew thanks, just did!

@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants