Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't run the tests #313

Closed
andrewrk opened this issue Jul 4, 2014 · 5 comments
Closed

can't run the tests #313

andrewrk opened this issue Jul 4, 2014 · 5 comments
Labels
third-party This issue is related to third-party libraries or applications.

Comments

@andrewrk
Copy link

andrewrk commented Jul 4, 2014

$ npm test

> aws-sdk@2.0.4 test /home/andy/dev/aws-sdk-js
> npm -s run-script lint && npm -s run-script unit && npm -s run-script buildertest && npm -s run-script browsertest && ([ -f configuration ] && npm -s run-script integration || true)


/home/andy/dev/aws-sdk-js/node_modules/jasmine-node/lib/jasmine-node/reporter.js:336
  jasmineNode.TeamcityReporter.prototype = new jasmine.TeamcityReporter;
                                           ^
TypeError: undefined is not a function
    at /home/andy/dev/aws-sdk-js/node_modules/jasmine-node/lib/jasmine-node/reporter.js:336:44
    at Object.<anonymous> (/home/andy/dev/aws-sdk-js/node_modules/jasmine-node/lib/jasmine-node/reporter.js:342:3)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/home/andy/dev/aws-sdk-js/node_modules/jasmine-node/lib/jasmine-node/index.js:34:21)
    at Module._compile (module.js:456:26)
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0
@lsegal
Copy link
Contributor

lsegal commented Jul 4, 2014

It looks like there's a regression in the latest jasmine-node. I noticed
build failures on Travis for this too.

On July 3, 2014 6:11:13 PM Andrew Kelley notifications@github.com wrote:

$ npm test

> aws-sdk@2.0.4 test /home/andy/dev/aws-sdk-js
> npm -s run-script lint && npm -s run-script unit && npm -s run-script 
buildertest && npm -s run-script browsertest && ([ -f configuration ] && 
npm -s run-script integration || true)


/home/andy/dev/aws-sdk-js/node_modules/jasmine-node/lib/jasmine-node/reporter.js:336
  jasmineNode.TeamcityReporter.prototype = new jasmine.TeamcityReporter;
                                           ^
TypeError: undefined is not a function
    at 
    /home/andy/dev/aws-sdk-js/node_modules/jasmine-node/lib/jasmine-node/reporter.js:336:44
    at Object.<anonymous> 
    (/home/andy/dev/aws-sdk-js/node_modules/jasmine-node/lib/jasmine-node/reporter.js:342:3)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> 
    (/home/andy/dev/aws-sdk-js/node_modules/jasmine-node/lib/jasmine-node/index.js:34:21)
    at Module._compile (module.js:456:26)
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

Reply to this email directly or view it on GitHub:
#313

@andrewrk
Copy link
Author

andrewrk commented Jul 4, 2014

I recommend locking the major and minor versions of dependencies, including devDependencies.

@lsegal
Copy link
Contributor

lsegal commented Jul 4, 2014

We typically do lock devDepencies to major versions-- jasmine-node was not. That said, locking to any version of jasmine-node in this case would not have resolved this failure as the regression occurred in a dependent package of jasmine-node. The only way we could have avoided this would be by generating a shrinkwrap, which unfortunately is not feasible. The workaround for now would be to run:

npm install jasmine-reporters@1.x

@lsegal
Copy link
Contributor

lsegal commented Jul 8, 2014

Fixed by a temporary adjustment to the package.json in db52a5b. I've actually been working on a long-running branch to move over to mocha, so I will work on that as a permanent fix.

@lsegal lsegal closed this as completed Jul 8, 2014
@srchase srchase added third-party This issue is related to third-party libraries or applications. and removed third-party labels Jan 4, 2019
@lock
Copy link

lock bot commented Sep 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
third-party This issue is related to third-party libraries or applications.
Projects
None yet
Development

No branches or pull requests

3 participants