chore(id-auth-sra): sigv4a compatibility for id-auth sra #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
chore/id-auth-3
branch
4 times, most recently
from
1946a8d
to
385a81d
Compare
2 tasks
kuhe
force-pushed
the
chore/id-auth-3
branch
4 times, most recently
from
2f3a0cd
to
98740af
Compare
trivikr
approved these changes
Aug 1, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires smithy-lang/smithy-typescript#1357
Enables sigv4a regionSet behavior for the ID&Auth signer by adding a new (pseudo) signer
AwsSdkSigV4ASigner extends AwsSdkSigV4Signer. This correctly passes the resolved signingRegionSet to the pre-existing signerConstructor instance, which is the adaptiveSignatureV4MultiRegionfor sigv4a services.centralizes detection of the sigv4a customization. For existing clients there is a 3-client hard-coded inclusion list. For future clients it will fall back to the spec's trait-based detection.
reduces the list of legacy auth services to just (1), namely S3. We will handle S3-Express customization in the next PR: chore(id-auth-sra): S3 Express compatibility with ID & Auth SRA #6346