Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): remove redundant service client doc generator #6041

Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 30, 2024

Issue

Codegen for smithy-lang/smithy-typescript#1253

Description

Removes redundant service client doc generator

Testing

Verified codegen doesn't re-add service client doc generator


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the remove-service-client-documentation-generator branch from 2118273 to e68fbfb Compare April 30, 2024 22:08
@trivikr
Copy link
Member Author

trivikr commented Apr 30, 2024

ToDo: update SMITHY_TS_COMMIT to commit after merging smithy-lang/smithy-typescript#1253, and rebase this PR.

@trivikr trivikr marked this pull request as ready for review May 1, 2024 14:49
@trivikr trivikr requested a review from a team as a code owner May 1, 2024 14:49
@trivikr trivikr merged commit 306aafc into aws:main May 1, 2024
3 checks passed
@trivikr trivikr deleted the remove-service-client-documentation-generator branch May 1, 2024 15:08
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants