chore(codegen): move s3 transform to Java code #5963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Apr 4, 2024
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This code should initially have been in Java anyway. However, at the time I couldn't figure out how to mutate the model, and wrote it in JS.
It turns out the .addX() methods on the various builders generally do a replace on a map collection, and it was easier to figure out this time.
trivikr
approved these changes
Apr 5, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This converts the s3 expires/expiresString custom model transform from JavaScript to Java.
This makes it easier for consumers of
smithy-typescript-aws-codegento use the transform.