Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add error metadata indicating clock skew correction #5830

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Feb 27, 2024

Issue

for smithy-lang/smithy-typescript#1170

Description

This PR adds an internal additional metadata field called "clockSkewCorrected" for the sigv4signer error handler. It indicates that the error resulted in a clock skew correction.

This will be used to retry as a transient error after the inclusion of smithy-lang/smithy-typescript#1170.

@kuhe kuhe requested a review from a team as a code owner February 27, 2024 17:00
@kuhe kuhe force-pushed the fix/retry branch 2 times, most recently from aea33cb to de0391c Compare February 27, 2024 17:10
@kuhe kuhe merged commit 46e5e8d into aws:main Feb 27, 2024
2 checks passed
@kuhe kuhe deleted the fix/retry branch February 27, 2024 17:55
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants