-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(credential-provider-node): use dynamic import for credential providers #5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example in conjunction with "package-bundling":
|
kuhe
force-pushed
the
feat/dynamic-import
branch
3 times, most recently
from
January 12, 2024 16:37
c9504c7
to
348c283
Compare
trivikr
approved these changes
Jan 12, 2024
16 tasks
kuhe
force-pushed
the
feat/dynamic-import
branch
2 times, most recently
from
January 18, 2024 21:34
8651aeb
to
9d2dff9
Compare
kuhe
force-pushed
the
feat/dynamic-import
branch
from
January 19, 2024 15:06
9d2dff9
to
e1792d3
Compare
4 tasks
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
await import()
or simple dynamicrequire()
calls.This avoids the issue of browser/bundler and react-native compatibility.
Testing
yarn test:e2e
yarn test:integration
import()
to arequire
) so there is no difference. ESBuild if used in the future does not convertimport()
torequire()
, but it does not need to.effects on SDK initialization times: