docs(types): improve streaming payload types #4987
Conversation
kuhe
force-pushed
the
feat/stream-typings
branch
2 times, most recently
from
bda01ce to
6b225cf
Compare
kuhe
force-pushed
the
feat/stream-typings
branch
2 times, most recently
from
4f56c9f to
c4867bf
Compare
|
kuhe
force-pushed
the
feat/stream-typings
branch
from
c4867bf to
b99dfea
Compare
| @@ -108,3 +108,36 @@ if (errors.length) { | |||
| const violations = errors.join(", "); | |||
| throw new Error(violations + " have inconsistent declared versions."); | |||
| } | |||
|
|
|||
| for (const pkg of nonClientPackages) { | |||
There was a problem hiding this comment.
The generated protocol test packages in /private should have their dependencies updated the same way as client packages. Should those get handled separately? They shouldn't ever be out of sync with the clients anyways, but this could potentially paper over an issue where they get updated independently of the right codegen changes being applied to those test packages.
There was a problem hiding this comment.
I've moved the private entries into the client list so they get checked and contribute to the canonical version that gets written to the rest of the packages.
kuhe
force-pushed
the
feat/stream-typings
branch
2 times, most recently
from
2473b26 to
68092dd
Compare
kuhe
force-pushed
the
feat/stream-typings
branch
from
68092dd to
a79f577
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
closes #4933
codegen for smithy-lang/smithy-typescript#835
Description
replaces inline union types representing payload blobs with a type alias (equivalent) that centralizes documentation and context for how to use those types.