fix(node-http-handler): call socket.setKeepAlive if enabled in http(s)Agent

[yenfryherrerafeliz]

When using node-http-handler and setting keep-alive to true in the agent configuration, this setup is not being honored by nodejs https library, due to a bug with the https lib from nodejs. To aid this issue at the SDK side what I am doing is enabling keep alive directly in the socket, by adding a listener for when a new socket is created, and there we provide the keep-alive settings to the socket.

Issue

Fixes #3624

Description

what I do is to add a listener for when a new socket is created then we pass the keep alive settings to that socket.
Example:

import { NodeHttpHandler }  from '@aws-sdk/node-http-handler';
import {InvokeCommand, LambdaClient} from "@aws-sdk/client-lambda";

const client = new LambdaClient({
    region: 'us-east-2',
    requestHandler: new NodeHttpHandler({
        httpsAgent: new Agent({
            keepAlive: true,
            keepAliveMsecs: 5 * 1000
        })
    })
})

And the configuration above will make the socket to send keep-alive packets every 5 seconds.

Testing

N/A

Additional context

I have also created the following issue under nodejs repo.

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[kuhe]

looks good, just need a unit test and some minor changes

[alfaproject]

Is this still a issue? Should we add this work-around in our clients until this is merged, or?

[trivikr]

Verified that keepAlive parameter is set on agent

import http from "http";

// Logs false in Node.js 14+
console.log("keepAlive from default agent:", new http.Agent().keepAlive);

// Logs false in Node.js 14+
console.log(
  "keepAlive from agent with keepAlive=false:",
  new http.Agent({ keepAlive: false }).keepAlive
);

// Logs true in Node.js 14+
console.log(
  "keepAlive from agent with keepAlive=true:",
  new http.Agent({ keepAlive: true }).keepAlive
);

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.