Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scripts): remove devDeps defined in monorepo root #3138

Merged
merged 2 commits into from
Jan 5, 2022
Merged

chore(scripts): remove devDeps defined in monorepo root #3138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c415cd2
chore(scripts): remove devDeps defined in monorepo root from clients
trivikr Jan 5, 2022
8343f08
chore(scripts): only add deps which are present in codegen
trivikr Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/generate-clients/copy-to-clients.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ const mergeManifest = (fromContent = {}, toContent = {}) => {
const merged = {};
for (const name of Object.keys(fromContent)) {
if (fromContent[name].constructor.name === "Object") {
if (name === "devDependencies") {
// Remove devDeps defined in monorepo root
const devDepsInRoot = ["downlevel-dts", "rimraf", "typedoc", "typescript"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked if we can also remove the @aws-sdk/service-client-documentation-generator?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to remove @aws-sdk/service-client-documentation-generator if it's defined in root package.json
We can take it up in a separate PR as it's an internal dependency and will need additional testing with docs generation.

devDepsInRoot.forEach((devDep) => delete fromContent[name][devDep]);
}
merged[name] = mergeManifest(fromContent[name], toContent[name]);
if (name === "scripts" || name === "devDependencies") {
// Allow target package.json(toContent) has its own special script or
Expand Down