docs: add documentation for destroy method #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2204 +/- ##
=======================================
Coverage ? 61.83%
=======================================
Files ? 453
Lines ? 23287
Branches ? 5516
=======================================
Hits ? 14399
Misses ? 8888
Partials ? 0 Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
Apr 1, 2021
JordonPhillips
pushed a commit
that referenced
this pull request
Apr 8, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2105
Related to: smithy-lang/smithy-typescript#301
Description
Since the
destroyis inherited from the underlying Node.js API agent.destroy(), and it doesn't actually destroy and disable the agent for the future use, we will keep thedestroy()method name in V3 SDK. This change adds documentation to clarify the confusion.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.