-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): pin fast-xml-parser to v3.17.4 #2102
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2102 +/- ##
=======================================
Coverage ? 78.65%
=======================================
Files ? 378
Lines ? 16024
Branches ? 3430
=======================================
Hits ? 12603
Misses ? 3421
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@trivikr why is codegen CI failing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 after fixing the CI failure
99879a3
to
1ad6e65
Compare
The CI was failing as the update on smithy-typescript wasn't updated smithy-lang/smithy-typescript#280 |
1ad6e65
to
36c954b
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@trivikr looks like they just removed the modifications: NaturalIntelligence/fast-xml-parser@1357c5d |
indeed - @amitguptagwl moved the library back to using standard MIT to allow (thanks @amitguptagwl for that ❤️). |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
N/A
Description
Pinning fast-xml-parser to v3.17.4 as the project switched to modified MIT License in >=v3.17.5 in NaturalIntelligence/fast-xml-parser@5d4e951
Testing
CI. Integration tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.