Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call filterSensitiveLog for missing structures #2089

Merged
merged 2 commits into from
Mar 4, 2021
Merged

fix: call filterSensitiveLog for missing structures #2089

merged 2 commits into from
Mar 4, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 26, 2021

Issue

Refs: smithy-lang/smithy-typescript#277

Description

Added missing filterSensitiveLog operations for some structures.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as draft February 26, 2021 04:16
@trivikr
Copy link
Member Author

trivikr commented Feb 26, 2021 •
edited
Loading

Converted to draft as #2090 needs to be merged first. Ready for review!

@trivikr trivikr force-pushed the fix-filterSensitiveLog branch from e107b40 to f743b47 Compare March 2, 2021 16:50
@trivikr trivikr marked this pull request as ready for review March 2, 2021 16:52
@codecov-io
Copy link

codecov-io commented Mar 2, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@05ef1b4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2089   +/-   ##
=======================================
  Coverage        ?   78.65%           
=======================================
  Files           ?      378           
  Lines           ?    16024           
  Branches        ?     3430           
=======================================
  Hits            ?    12603           
  Misses          ?     3421           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ef1b4...81d1562. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 81d1562
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@alexforsyth
Copy link
Contributor

LGTM, gave +1. Pending approval on smithy-lang/smithy-typescript#277

alexforsyth
alexforsyth approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr merged commit 1b5cb0f into aws:main Mar 4, 2021
@trivikr trivikr deleted the fix-filterSensitiveLog branch March 4, 2021 18:26
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

@alexforsyth alexforsyth alexforsyth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trivikr @codecov-io @aws-sdk-js-automation @alexforsyth @AllanZhengYP