Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(packages): use types as a declarationDir #1938

Merged
merged 4 commits into from
Jan 21, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 21, 2021

Issue #, if available:
Refs: #1919 (comment)

Description of changes:
This issue was noticed while working on fix for #1919

Using "./types" as a declarationDir in non-clients for the following reasons:

  • The "./types" is used as a declarationDir already in clients.
  • The types are independent of commonjs or esm modules.
  • The legacy types can be generated as a postbuild step for types folder.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: b4a7dc9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, LGTM

.gitignore Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants