-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example config to be propagated across packages #1279
Conversation
Key points:
|
Codecov Report
|
|
||
"module": "commonjs", | ||
"moduleResolution": "node", | ||
"target": "es5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target should be browser TSConfig target, as that's usually the lower version of ECMAScript.
"module": "commonjs", | ||
"moduleResolution": "node", | ||
"target": "es5", | ||
"lib": ["es2015", "dom"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decided to exclude lib, as it's overridden in individual clients
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Description of changes:
Experimental PR to show how we'd implement a root tsconfig. This works properly for the abort controller package
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.