chore(smithy-client): skip emitting warning for Node.js 12.x (#4127)

aws · Nov 1, 2022 · 33f5ef6 · 33f5ef6
1 parent ffec8bd
commit 33f5ef6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/packages/smithy-client/src/emitWarningIfUnsupportedVersion.spec.ts b/packages/smithy-client/src/emitWarningIfUnsupportedVersion.spec.ts
@@ -1,4 +1,4 @@
-describe("emitWarningIfUnsupportedVersion", () => {
+describe.skip("emitWarningIfUnsupportedVersion", () => {
   let emitWarningIfUnsupportedVersion;
   const emitWarning = process.emitWarning;
   const supportedVersion = "14.0.0";

diff --git a/packages/smithy-client/src/emitWarningIfUnsupportedVersion.ts b/packages/smithy-client/src/emitWarningIfUnsupportedVersion.ts
@@ -9,13 +9,14 @@ let warningEmitted = false;
 export const emitWarningIfUnsupportedVersion = (version: string) => {
   if (version && !warningEmitted && parseInt(version.substring(1, version.indexOf("."))) < 14) {
     warningEmitted = true;
-    process.emitWarning(
-      `The AWS SDK for JavaScript (v3) will\n` +
-        `no longer support Node.js ${version} on November 1, 2022.\n\n` +
-        `To continue receiving updates to AWS services, bug fixes, and security\n` +
-        `updates please upgrade to Node.js 14.x or later.\n\n` +
-        `For details, please refer our blog post: https://a.co/48dbdYz`,
-      `NodeDeprecationWarning`
-    );
+    // ToDo: Turn back warning for future Node.js version deprecation
+    // process.emitWarning(
+    //   `The AWS SDK for JavaScript (v3) will\n` +
+    //     `no longer support Node.js ${version} on November 1, 2022.\n\n` +
+    //     `To continue receiving updates to AWS services, bug fixes, and security\n` +
+    //     `updates please upgrade to Node.js 14.x or later.\n\n` +
+    //     `For details, please refer our blog post: https://a.co/48dbdYz`,
+    //   `NodeDeprecationWarning`
+    // );
   }
 };